New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mock https server and redo start of browser tests for this purpose. #1342
Conversation
Excellent work, thank you! I'll merge this tomorrow if no one objects or beats me to it. For some context, we were getting 403 Forbidden from the GitHub API when running on Travis, which caused the build in #1341 to fail. |
Sounds good :) And of course it was about time we had tests not relying on 3rd party APIs. That being said, when trying to get the tests to run with ignoring the self signed cert I noticed that the error message is not so descriptive if you get an "aborted" request like that (meaning the request never really gets a status code) in the browser. I'll see if I can track it down and/or open an issue about it one of these days |
Ah, sorry. I did not see that PR or take part in that discussion, but I see it now. And makes sense. If it ends up being defined in one of the test files, it should probably be pulled from there later. As of now (since this is not in master yet) I just changed the port. |
For reference (for me and others), this is the issue in question: #1337 Nice issue number :p |
Actually 1337 is a good port number too :) |
I want to go ahead and get this in, thanks again @eiriksm! |
Add mock https server and redo start of browser tests for this purpose.
This is a suggestion ref #1308.
Using a mock https server, and starting karma as a child process. Let me know if I should change something around :)